Page 1 of 1
Notch on Cygwin -Bug report
Posted: 2013-08-10T08:32:40-07:00
by markanini
Probably needs confirmation but the -R and -B parameters seem broken. Acts as if all -L -R -B -U parameters are at 0. -L and -U work as expecterd individually and in combination however.
Re: Notch on Cygwin -Bug report
Posted: 2013-08-10T09:03:53-07:00
by fmw42
There was a typo for -R (right) that I have now fixed. On quick review, I do not see anything else obviously wrong. I do not have time this morning to test further, but I will try to look at it later today. In the mean time, download the updated version and try it again and let me know what you find. If possible provide a link to the image you are testing, so I can test with it also, if needed.
Re: Notch on Cygwin -Bug report
Posted: 2013-08-10T09:17:18-07:00
by markanini
That was quick!
Unfortunately I see the same behaviour with the updated script.
Re: Notch on Cygwin -Bug report
Posted: 2013-08-10T09:41:16-07:00
by dlemstra
Code: Select all
if [ "$right" != "0" ]; then
right=`convert xc: -format "%[fx:2*$right]" info:`
masking="-strokewidth $right -draw \"line $lastcol,0 $lastcol,$lastrow\""
fi
if [ "$bottom" != "0" ]; then
bottom=`convert xc: -format "%[fx:2*$bottom]" info:`
masking="-strokewidth $bottom -draw \"line 0,$lastrow $lastcol,$lastrow\""
fi
is missing, it should be:
Code: Select all
if [ "$right" != "0" ]; then
right=`convert xc: -format "%[fx:2*$right]" info:`
masking="$masking -strokewidth $right -draw \"line $lastcol,0 $lastcol,$lastrow\""
fi
if [ "$bottom" != "0" ]; then
bottom=`convert xc: -format "%[fx:2*$bottom]" info:`
masking="$masking -strokewidth $bottom -draw \"line 0,$lastrow $lastcol,$lastrow\""
fi
Re: Notch on Cygwin -Bug report
Posted: 2013-08-10T10:35:50-07:00
by fmw42
dlemstra wrote:
$masking is missing, it should be:
[/code]
Thanks dlemstra! I missed that earlier this morning on my quick review before I had to go out. You have a good eye.
I have made the fix and uploaded it. Sorry for the errors.
Let me know if that fixes it. If not I will look further.
Fred
Re: Notch on Cygwin -Bug report
Posted: 2013-08-10T10:50:27-07:00
by markanini
Works fine!
Re: Notch on Cygwin -Bug report
Posted: 2013-08-10T10:56:14-07:00
by fmw42
markanini wrote:Works fine!
Great! Thanks for notifying me and thanks to dlemstra for catching what I had missed.