IM 7.0.1-9: --enable-indirect-reads (@ in filenames) doesn't actually enable indirect reads

Post any defects you find in the released or beta versions of the ImageMagick software here. Include the ImageMagick version, OS, and any command-line required to reproduce the problem. Got a patch for a bug? Post it here.
Post Reply
Russtopia
Posts: 1
Joined: 2016-07-13T22:51:42-07:00
Authentication code: 1151

IM 7.0.1-9: --enable-indirect-reads (@ in filenames) doesn't actually enable indirect reads

Post by Russtopia » 2016-07-13T23:06:05-07:00

Commit ea78ffad71fb391e3d1616d05ad1bade7e53f295 introduced a configure flag, --enable-indirect-reads, to re-enable the (insecure) '@*' indirect read syntax. However there were typos in the variables introduced by this patch in configure and configure.ac, causing the feature to not actually be re-enabled when specifying --enable-indirect-reads.

While this patch has been superceded by commit f435e8724ade942148d065a4b898a0ed0c42c368 to version 7.0.1-10, which allows enabling indirect reads by use of policy.xml rather than a configure flag, at least one Linux distro (Gentoo 4.9.3, as of July 3, 2016) only packages up to version 7.0.1-9 with the aforementioned defective patch ea78ff.

For anyone using v7.0.1-9 wishing to compile with --enable-indirect-flags, please apply the following patch:
(on Gentoo, put the patch into /etc/portage/patches/media-gfx/imagemagick-7.0.1.9/)

Code: Select all

diff --git a/configure b/configure
index 0b23d9a..d6fd9e9 100755
--- a/configure
+++ b/configure
@@ -23851,7 +23851,7 @@ else
 fi


-if test "$enable_indirect-reads" = 'yes'; then
+if test "$enable_indirect_reads" = 'yes'; then

 $as_echo "#define INDIRECT_READS_SUPPORT 1" >>confdefs.h

diff --git a/configure.ac b/configure.ac
index 520f180..39dae55 100644
--- a/configure.ac
+++ b/configure.ac
@@ -703,7 +703,7 @@ AC_ARG_ENABLE([indirect-reads],
     [enable_indirect_reads=$enableval],
     [enable_indirect_reads='no'])

-if test "$enable_indirect-reads" = 'yes'; then
+if test "$enable_indirect_reads" = 'yes'; then
     AC_DEFINE(INDIRECT_READS_SUPPORT,1,[enable indirect reads (@) in filenames])
     MAGICK_FEATURES="IndirectReads $MAGICK_FEATURES"
 fi

Post Reply