-modulate in HCLp

Post any defects you find in the released or beta versions of the ImageMagick software here. Include the ImageMagick version, OS, and any command-line required to reproduce the problem. Got a patch for a bug? Post it here.
Post Reply
User avatar
GreenKoopa
Posts: 457
Joined: 2010-11-04T17:24:08-07:00
Authentication code: 8675308

-modulate in HCLp

Post by GreenKoopa »

-modulate works in HCL, but not in HCLp.

Searching the source I find 11 instances of HCLColorspace, but only 8 of HCLpColorspace. The instance missing in enhance.c is likely causing this issue.

Demonstration of the problem:

Code: Select all

convert hald:10 -colorspace Rec601Luma Luma.png
convert hald:10 -colorspace HCL  -channel G -evaluate Set 0 -colorspace sRGB HCL_set.png
convert hald:10 -colorspace HCLp -channel G -evaluate Set 0 -colorspace sRGB HCLp_set.png
convert hald:10 -define modulate:colorspace=HCL  -modulate 100,0,100 HCL_modulate.png
convert hald:10 -define modulate:colorspace=HCLp -modulate 100,0,100 HCLp_modulate.png

compare -metric PAE Luma.png HCL_set.png null:
compare -metric PAE Luma.png HCLp_set.png null:
compare -metric PAE Luma.png HCL_modulate.png null:
compare -metric PAE Luma.png HCLp_modulate.png null:

--- Output ---
1 (1.5259e-005)
1 (1.5259e-005)
1 (1.5259e-005)
25274 (0.385657)
User avatar
magick
Site Admin
Posts: 11064
Joined: 2003-05-31T11:32:55-07:00

Re: -modulate in HCLp

Post by magick »

We can reproduce the problem you posted and have a patch in ImageMagick 6.8.6-7 Beta available by sometime tomorrow. Thanks.
User avatar
GreenKoopa
Posts: 457
Joined: 2010-11-04T17:24:08-07:00
Authentication code: 8675308

Re: -modulate in HCLp

Post by GreenKoopa »

I see the change in the source code
http://www.imagemagick.org/download/win ... indows.zip
but the behavior is the same in the new version
http://www.imagemagick.org/download/bin ... 64-dll.exe
The fix seemed easy, unless the source didn't make it into the new build?
User avatar
dlemstra
Posts: 1570
Joined: 2013-05-04T15:28:54-07:00
Authentication code: 6789
Contact:

Re: -modulate in HCLp

Post by dlemstra »

I am having the same issue with the fix for this: viewtopic.php?f=3&t=20615. It looks like the recent changes did not make it into the windows build.
.NET + ImageMagick = Magick.NET https://github.com/dlemstra/Magick.NET, @MagickNET, Donate
User avatar
GreenKoopa
Posts: 457
Joined: 2010-11-04T17:24:08-07:00
Authentication code: 8675308

Re: -modulate in HCLp

Post by GreenKoopa »

Appears fixed in the new 6.8.6-7 release. Thank you.
Post Reply