Page 1 of 1
Magick++ STL.h
Posted: 2013-07-07T11:29:23-07:00
by dlemstra
Is it possible to add the following methods to STL.h:
MagickCore::CombineImages
MagickCore::EvaluateImages
MagickCore::MergeImageLayers
MagickCore::OptimizeImageLayers
MagickCore::OptimizePlusImageLayers
MagickCore::SeparateImages
And modify linkImages? The current code results in a false positive from Code Analysis.
Before:
Code: Select all
current->next = 0;
if ( previous != 0)
previous->next = current;
current->scene=scene;
++scene;
After:
Code: Select all
current->next = 0;
current->scene = scene++;
if ( previous != 0)
previous->next = current;
Re: Magick++ STL.h
Posted: 2013-07-07T15:31:59-07:00
by magick
Give us a week or so. Look for the patches in ImageMagick 6.8.6-4 beta.
Re: Magick++ STL.h
Posted: 2013-07-08T04:46:17-07:00
by dlemstra
Thanks for the quick response, I can supply you with a patch for the methods if you are interested.
Re: Magick++ STL.h
Posted: 2013-07-08T05:00:02-07:00
by magick
Thanks for the quick response, I can supply you with a patch for the methods if you are interested.
Of course. Post a URL to your patches so we can download them and apply them to the ImageMagick Subversion trunk. Thanks.
Re: Magick++ STL.h
Posted: 2013-07-08T05:54:49-07:00
by dlemstra
Is there an e-mail address e.g., 'patches at imagemagick.org' I can mail a patch to?
Re: Magick++ STL.h
Posted: 2013-07-08T06:22:07-07:00
by magick
Yes, use patches at imagemagick dot org.
Re: Magick++ STL.h
Posted: 2013-07-09T07:02:18-07:00
by magick
A few of the patches in Geometry.{cpp,h} did not stick. Download the latest and send us the differences from your source modules. Thanks.
Re: Magick++ STL.h
Posted: 2013-07-09T07:54:45-07:00
by dlemstra
I already mailed a second set of patches (with revision 12637).
Is the public repository copied from an internal repository? When i checked the logs at
http://trac.imagemagick.org/log/ it said the changes where made 8 hours ago. But when I checked the logs 4 hours earlier I could not see those changes. Or is that a because of the timezone difference with Europe?
Re: Magick++ STL.h
Posted: 2013-07-09T09:31:21-07:00
by magick
trac.imagemagick.org can be up to 24 hours stale. The authoritative Subversion trunk is @ subversion.imagemagick.org.
Re: Magick++ STL.h
Posted: 2013-07-09T10:48:48-07:00
by dlemstra
I figured out what went wrong. I was using the url '
https://www.imagemagick.org/subversion' instead of '
https://subversion.imagemagick.org/subversion'. I found that url here: '
http://www.imagemagick.org/script/subversion.php'. I will email another set of patches.
Re: Magick++ STL.h
Posted: 2013-07-09T11:58:44-07:00
by magick
Patches applied. Thanks.