ABI/API breakage : please so bump and do a new release

Post any defects you find in the released or beta versions of the ImageMagick software here. Include the ImageMagick version, OS, and any command-line required to reproduce the problem. Got a patch for a bug? Post it here.
Locked
broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

ABI/API breakage : please so bump and do a new release

Post by broucaries »

Hi,

Did you check ABI/API using upstream tracker ?

http://upstream-tracker.org/compat_repo ... eport.html

AccelerateConvolveImage ( Image const* image, KernelInfo const* kernel, Image* convolve_image, ExceptionInfo* exception ) (2)
changed to:
AccelerateConvolveImage ( Image const* p1, enum ChannelType const p2, KernelInfo const* p3, ExceptionInfo* p4 )

Please add autotest by using local http://ispras.linuxbase.org/index.php/Upstream_Tracker. It is quite easy to run and instead of downloading from the public repositionnery you could download from the private and thus get some time to correct mistakes

So now you need a so dump. Please do like the previous so dump for magick++ in order to not dump magickwand.

Bastien

broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: ABI/API breakage : please so bump and do a new release

Post by broucaries »

It seems that you have not released officially the faulting version (it is not under public download) so you could may be correct the ABI breakage.

Bastien

User avatar
magick
Site Admin
Posts: 11254
Joined: 2003-05-31T11:32:55-07:00

Re: ABI/API breakage : please so bump and do a new release

Post by magick »

We have a new developer for the GPU acceleration codes. We'll have him fix the API breakage. Stand by...

broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: ABI/API breakage : please so bump and do a new release

Post by broucaries »

I see it is a beta release

In this case could you named it with
#define MagickppLibAddendum "-10~beta20130826" in order for to classify the version correctly (~ is before any other version).

I will send a mail to andrew the upstream tracker in order to check consistently the beta version

Bastien

User avatar
magick
Site Admin
Posts: 11254
Joined: 2003-05-31T11:32:55-07:00

Re: ABI/API breakage : please so bump and do a new release

Post by magick »

Thanks for the Beta tracker. That will permit us to fix any warnings / errors *before* we make an official release.

broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: ABI/API breakage : please so bump and do a new release

Post by broucaries »

And if you see the upstream tracker, you get also a SVN tracker once per day (see mail a at patch address)

broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: ABI/API breakage : please so bump and do a new release

Post by broucaries »

And please remove we beta tar.* from the beta directory and rename it ~beta`date`.tar.*

I will ask to andrew to rerun upstream tracker when in order to see beta.

Bastien

User avatar
magick
Site Admin
Posts: 11254
Joined: 2003-05-31T11:32:55-07:00

Re: ABI/API breakage : please so bump and do a new release

Post by magick »

Done.

Locked