Sourceless file and privacy problem

Post any defects you find in the released or beta versions of the ImageMagick software here. Include the ImageMagick version, OS, and any command-line required to reproduce the problem. Got a patch for a bug? Post it here.
Post Reply
broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Sourceless file and privacy problem

Post by broucaries » 2015-09-16T10:39:36-07:00

Hi,

Could you please add the source of magick.js ?

This is a non distributable source due to lack of license and lack of source.

Bastien

broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: Sourceless file and privacy problem

Post by broucaries » 2015-09-16T10:42:04-07:00

BTW the magick css is not suitable for debian.

Could we get the uncompressed version ?

User avatar
magick
Site Admin
Posts: 10994
Joined: 2003-05-31T11:32:55-07:00

Re: Sourceless file and privacy problem

Post by magick » 2015-09-16T12:59:46-07:00

magick.css and magick.js are optimized versions of Bootstrap css. Check Git. We added the requisite copyright statement.

broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: Sourceless file and privacy problem

Post by broucaries » 2015-09-16T13:02:46-07:00

It is still undistributable because we could not reproduce the build (it fail to build from source). What is the exact version used ? It should be documented and we will regenerate it at each build.

Bastien

broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: Sourceless file and privacy problem

Post by broucaries » 2015-09-16T13:05:42-07:00

You could put the source in a src/ subdirectory, and you will get the speedup of minified and downstream will be happy

User avatar
magick
Site Admin
Posts: 10994
Joined: 2003-05-31T11:32:55-07:00

Re: Sourceless file and privacy problem

Post by magick » 2015-09-16T13:55:58-07:00

We passed Twitters bootstrap.min.css through Google's optimizer. We also have a custom changes that override Bootstrap. It is sufficient to just add bootstrap.css to www/css to meet the Debian requirements?

broucaries
Posts: 467
Joined: 2008-12-21T11:51:10-07:00

Re: Sourceless file and privacy problem

Post by broucaries » 2015-09-16T13:58:43-07:00

Debian/ubuntu ban minified stuff without source.

If you add non minified version somewhere in the tree it will work (css and js file). So adding source is sufficient. We will recompile if needed or use upstream version (I can even cook a patch in order to regererate the minified stuff in html file).

Bastien

User avatar
magick
Site Admin
Posts: 10994
Joined: 2003-05-31T11:32:55-07:00

Re: Sourceless file and privacy problem

Post by magick » 2015-09-16T14:02:28-07:00

Done, added bootstrap.css and bootstrap.js to the distribution.

Post Reply