ImageMagick-6.8.8-10 _JP2_DELEGATE vs. _LIBOPENJP2_DELEGATE

Post any defects you find in the released or beta versions of the ImageMagick software here. Include the ImageMagick version, OS, and any command-line required to reproduce the problem. Got a patch for a bug? Post it here.
Post Reply
Posts: 5
Joined: 2014-04-06T05:01:28-07:00
Authentication code: 6789

ImageMagick-6.8.8-10 _JP2_DELEGATE vs. _LIBOPENJP2_DELEGATE

Post by ssuominengentoo »

There are some confusion about defines of MAGICKCORE_JP2_DELEGATE and MAGICKCORE_LIBOPENJP2_DELEGATE that was reported by Alexander Miller at: (This specific comment in the bug, not others.)

The patch for easy fetching,

However I strongly urge to "grep" the whole source tree of ImageMagick since even with this patch, I see both defines being used, some are in, for example, config.h_vms that this patch doesn't cover.

I see similar issue was reported in past, but only part of the files was fixed for it... likely caused by the lack of double checking by the "grep" like I suggested above.

The patch that fixes the most important parts:

Code: Select all

--- coders/pdf.c
+++ coders/pdf.c
@@ -1276,7 +1276,7 @@ RestoreMSCWarning
       case JPEG2000Compression:
--- magick/version.c
+++ magick/version.c
@@ -141,7 +141,7 @@ MagickExport const char *GetMagickDelega
   "jng "
   "jp2 "
User avatar
Site Admin
Posts: 11064
Joined: 2003-05-31T11:32:55-07:00

Re: ImageMagick-6.8.8-10 _JP2_DELEGATE vs. _LIBOPENJP2_DELEG

Post by magick »

We applied your patch to the Subversion trunk. Look for it in the ImageMagick 6.9.0-0 release within a week or two. Thanks.
Post Reply